Skip to content

Comments

Fix handling metadata values in the query API#14

Merged
Nuvindu merged 7 commits intomainfrom
metadata-fix
Sep 11, 2025
Merged

Fix handling metadata values in the query API#14
Nuvindu merged 7 commits intomainfrom
metadata-fix

Conversation

@Nuvindu
Copy link
Contributor

@Nuvindu Nuvindu commented Sep 11, 2025

Purpose

Fixes: ballerina-platform/ballerina-library#8238, ballerina-platform/ballerina-library#8239

This PR fixes the followings,

  • Fix handling metadata values in the query API
  • Added v1 at the end of the service url path
  • Use TextChunks as the type for chunks returned from the query results

@codecov
Copy link

codecov bot commented Sep 11, 2025

Codecov Report

❌ Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.63%. Comparing base (443292b) to head (8943b31).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
ballerina/utils.bal 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
+ Coverage   61.98%   69.63%   +7.64%     
==========================================
  Files           2        2              
  Lines         171      191      +20     
  Branches       63       68       +5     
==========================================
+ Hits          106      133      +27     
+ Misses         65       58       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

MohamedSabthar
MohamedSabthar previously approved these changes Sep 11, 2025
@Nuvindu Nuvindu merged commit 9c3894c into main Sep 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use ai:TextChunk instead of ai:Chunk in query results

2 participants