Update delete, query APIs to support new changes#8
Merged
Nuvindu merged 19 commits intoballerina-platform:mainfrom Aug 31, 2025
Merged
Update delete, query APIs to support new changes#8Nuvindu merged 19 commits intoballerina-platform:mainfrom
Nuvindu merged 19 commits intoballerina-platform:mainfrom
Conversation
ballerina/vector_store.bal
Outdated
| foreach string id in ids.cloneReadOnly() { | ||
| ai:Error? result = deleteById(id, path, self.weaviateClient); | ||
| if result is error { | ||
| return result; |
There was a problem hiding this comment.
This leads to an inconsistent stage.
Some are deleted and some are not.
Contributor
Author
There was a problem hiding this comment.
Used a transaction block as suggested
Fixed in 4c2b6cd
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
==========================================
- Coverage 65.58% 61.98% -3.60%
==========================================
Files 2 2
Lines 154 171 +17
Branches 49 63 +14
==========================================
+ Hits 101 106 +5
- Misses 53 65 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MohamedSabthar
approved these changes
Aug 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
$subject