Skip to content

Comments

Decouple persist tool from the distribution#404

Merged
daneshk merged 20 commits intoballerina-platform:mainfrom
daneshk:decouple-tool
Jun 20, 2025
Merged

Decouple persist tool from the distribution#404
daneshk merged 20 commits intoballerina-platform:mainfrom
daneshk:decouple-tool

Conversation

@daneshk
Copy link
Member

@daneshk daneshk commented May 29, 2025

Purpose

Fixes: ballerina-platform/ballerina-library#7962

Examples

Checklist

  • Linked to an issue
  • Updated the specification
  • Updated the changelog
  • Added tests

@codecov
Copy link

codecov bot commented Jun 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.80%. Comparing base (3bb9478) to head (78bd00e).
Report is 22 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #404      +/-   ##
==========================================
- Coverage   85.81%   85.80%   -0.02%     
==========================================
  Files          66       66              
  Lines        6241     6241              
  Branches      838      838              
==========================================
- Hits         5356     5355       -1     
  Misses        647      647              
- Partials      238      239       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@daneshk daneshk marked this pull request as ready for review June 19, 2025 15:47
@daneshk daneshk requested a review from Copilot June 19, 2025 15:48
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR decouples the persist tool from the distribution and introduces a new Gradle project for the persist tool along with corresponding configuration and test changes.

  • Added a new persist-tool module with its own build script, Ballerina.toml, BalTool.toml, and README.
  • Updated settings, build configurations, and test projects to reflect the decoupling and new persist-tool integration.

Reviewed Changes

Copilot reviewed 17 out of 18 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
settings.gradle Added plugin management block and included the new persist-tool.
persist-tool/* New persist-tool module files including build, source, and config.
persist-cli/build.gradle Added manifest attributes for build artifacts.
persist-cli-tests/* Updated tests with added logging and minor refactoring changes.
persist-cli-tests/build.gradle Refactored copy tasks and added a new task to update bal-tools.toml.
examples/build.gradle Updated tasks to incorporate the new persist-tool build and update flows.
gradle.properties Updated version and dependency properties.
build-config/resources/* New configuration files to support persist-tool.

@sonarqubecloud
Copy link

Copy link

@DimuthuMadushan DimuthuMadushan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@daneshk daneshk merged commit b612ecb into ballerina-platform:main Jun 20, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Decouple bal persist tool from the Distribution

2 participants