VertexAttributeValues supports more VertexFormat#22796
Open
beicause wants to merge 2 commits intobevyengine:mainfrom
Open
VertexAttributeValues supports more VertexFormat#22796beicause wants to merge 2 commits intobevyengine:mainfrom
VertexAttributeValues supports more VertexFormat#22796beicause wants to merge 2 commits intobevyengine:mainfrom
Conversation
kfc35
added
A-Rendering
github-project-automation
bot
moved this to Needs SME Triage
in Rendering (2026 Proposal)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Some wgpu
VertexFormats are not supported byVertexAttributeValues.Solution
Add them to
VertexAttributeValues.Float64 is not supported by any wgpu backends but I added them anyway because wgpu has them.
May require #22187 to be fixed because for vertex formats less than 32 bits the
MeshBufferSlice::rangeis incorrect. But generally vertex attributes are not affected by that issue if indices isn't u16.Testing
None