Fixes for atlas validation. #358
Closed
+67
−405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…used file check to account for atlas descriptions, add schema version to non json output.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #358 +/- ##
=======================================
Coverage 87.53% 87.53%
=======================================
Files 51 51
Lines 3924 3924
Branches 630 630
=======================================
Hits 3435 3435
Misses 479 479
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
effigies
reviewed
Feb 11, 2026
Comment on lines
14
to
18
| - Bumped schema version to 1.2.0 | ||
|
|
||
| ### Fixed | ||
|
|
||
| - Uncaught error caused during directory rule matching when datasetType is not a known value to the schema. |
Contributor
| ### Fixed | ||
|
|
||
| - Uncaught error caused during directory rule matching when datasetType is not a known value to the schema. | ||
| - Atlas description files added to the unused file check exemption list. |
Contributor
There was a problem hiding this comment.
I'm really surprised this wasn't caught in the examples. Any notion why not?
Member
Author
There was a problem hiding this comment.
I'm not seeing the issue in main. I was testing on an outdated branch. x_x
…e fix in favor of existing one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered while trying to bidsify xcp_d atlas directory. Atlases validated against: PennLINC/xcp_d#1580