Skip to content

Fixes for atlas validation. #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rwblair wants to merge 4 commits into from
Closed

Fixes for atlas validation. #358

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
96ce573
Fix issues with directory rule validation and dataset type, update un…
rwblair Feb 11, 2026
56f5512
Merge branch 'main' of github.com:bids-standard/bids-validator into f…
rwblair Feb 11, 2026
5bf2669
add changelog
rwblair Feb 11, 2026
3d31489
Why wouldn't you merge main before testing things? Undoing datasettyp…
rwblair Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions changelog.d/20260211_134215_rosswilsonblair_misc_atlas.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
<!--
A new scriv changelog fragment.

Uncomment the section that is right (remove the HTML comment wrapper).
For top level release notes, leave all the headers commented out.
-->

### Added

- Print schema version in standard output summary.

### Changed

- Bumped schema version to 1.2.0

### Fixed

- Uncaught error caused during directory rule matching when datasetType is not a known value to the schema.
Copy link
Contributor

@effigies effigies Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two were already done in c20c599 and dfd1ae1.

- Atlas description files added to the unused file check exemption list.
Copy link
Contributor

@effigies effigies Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really surprised this wasn't caught in the examples. Any notion why not?

Copy link
Member Author

@rwblair rwblair Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing the issue in main. I was testing on an outdated branch. x_x


<!--
### Deprecated

- A bullet item for the Deprecated category.

-->
<!--
### Removed

- A bullet item for the Removed category.

-->
<!--
### Security

- A bullet item for the Security category.

-->
<!--
### Infrastructure

- A bullet item for the Infrastructure category.

-->
Loading
Loading