Add get_pre_1_wallet_keychains migration helper#364
Add get_pre_1_wallet_keychains migration helper#364notmandatory wants to merge 1 commit intobitcoindevkit:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #364 +/- ##
==========================================
+ Coverage 85.33% 85.38% +0.04%
==========================================
Files 24 25 +1
Lines 8335 8407 +72
==========================================
+ Hits 7113 7178 +65
- Misses 1222 1229 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4751fac to
366ca7a
Compare
|
Part of this PR (rather a sidequest to this PR) could include updating the Migrating from 0.X page on the book of bdk, since this approach is simpler and requires less code, and I think it could simply supercede what we have there (or at least be added as a secondary section/option). Also would be great to add a small feature page on the Release Guide when we do push the 2.4 section of the Release Guide. I keep track of the features I think should be highlighted here. |
|
Two things I'd like to clarify maybe:
|
The only sqlite tables this function uses is
Unfortunately pre-1.0 we did not persist the descriptor string in the sqlite db, all wallet constructors required you pass in your descriptor(s), see: pre-1.0 Wallet docs. All we have in the pre-1.0 sqlite db are the descriptor checksums. |
Description
Add
wallet/migrationmodule andget_pre_1_wallet_keychains()to help migrate users from a pre-1.0 bdk sqlite database. This new function returns the last revealed index and checksum value for each keychain it finds.Notes to the reviewers
This PR replaces bitcoindevkit/bdk#2090 since make more sense to put it in the wallet where it will be easier to export the bindings.
Changelog notice
get_pre_1_wallet_keychainsto assist migration from pre-1.0 bdk wallets.Checklists
All Submissions:
just pbefore pushingNew Features: