Fixed the move semantics related and other issues reported by the newer clang compiler.#153
Open
safaruqi wants to merge 2 commits intobloomberg:masterfrom
Open
Fixed the move semantics related and other issues reported by the newer clang compiler.#153safaruqi wants to merge 2 commits intobloomberg:masterfrom
safaruqi wants to merge 2 commits intobloomberg:masterfrom
Conversation
safaruqi
force-pushed
the
move_semantics_fix
branch
from
75abdf6 to
149bc7a
Compare
Contributor
Author
|
Travis Ci passed for g++ C++ standard 11, 14, & 17. For clang it passed for C++ 14 & 17 but is failing for c++11. WIl look at it when I find some time next. |
accelerated
reviewed
Sep 28, 2021
Contributor
accelerated
left a comment
accelerated
left a comment
There was a problem hiding this comment.
Looks solid. I think it's the right approach as providing move-semantics for synchronization types doesn't make sense and as such should be kept deleted
…ang compiler Fixed deprecated gtest macro warnings Signed-off-by: Salman Faruqi <sfaruqi@yahoo.com>
safaruqi
force-pushed
the
move_semantics_fix
branch
from
149bc7a to
b4c5e1c
Compare
Contributor
|
@safaruqi @arosenzweig3 any updates on this merge? Seems like it's holding up some folks... |
Contributor
|
This looks good to me, just getting another set of eyes on it before we merge. |
Shuvohasn
reviewed
May 15, 2025
Shuvohasn
left a comment
Shuvohasn
left a comment
There was a problem hiding this comment.
quantum/impl/quantum_task_queue_impl.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
*Issue number of the reported bug or feature request: #150 *
Describe your changes
Fixed all of the move semantics related and other issues reported by the newer clang compiler.
Testing performed
Was able to run all the included tests successfully which tests the whole fixture and primitives.
Additional context