btcec/schnorr: fix incorrect comment about nonce generation #2477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comments in schnorrSign and Sign incorrectly stated that CustomNonce triggers RFC6979 nonce generation. The actual behavior is the opposite: - With CustomNonce: BIP-340 compliant nonce derivation (steps 6-8) - Without CustomNonce (default): RFC6979 deterministic nonce generation Also fixes typo "set 14" -> "step 14".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comments in schnorrSign and Sign incorrectly stated that CustomNonce triggers RFC6979 nonce generation. The actual behavior is the opposite:
Also fixes typo "set 14" -> "step 14".