Skip to content

btcec/schnorr: fix incorrect comment about nonce generation #2477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
erickcestari wants to merge 1 commit into
base: master
Choose a base branch
from
Open

btcec/schnorr: fix incorrect comment about nonce generation #2477

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions btcec/schnorr/signature.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,9 +275,11 @@ func schnorrSign(privKey, nonce *btcec.ModNScalar, pubKey *btcec.PublicKey, hash
// 15. return sig.
//
// Note that the set of functional options passed in may modify the
// above algorithm. Namely if CustomNonce is used, then steps 6-8 are
// replaced with a process that generates the nonce using rfc6979. If
// FastSign is passed, then we skip set 14.
// above algorithm. If CustomNonce is used, steps 6-8 follow BIP-340's
// nonce derivation using the provided auxiliary randomness. If CustomNonce
// is NOT used (the default), steps 6-8 are replaced with RFC6979 nonce
// generation for deterministic signing. If FastSign is passed, we skip
// step 14 (signature verification).

// NOTE: Steps 1-9 are performed by the caller.

Expand Down Expand Up @@ -424,9 +426,11 @@ func Sign(privKey *btcec.PrivateKey, hash []byte,
// 15. return sig.
//
// Note that the set of functional options passed in may modify the
// above algorithm. Namely if CustomNonce is used, then steps 6-8 are
// replaced with a process that generates the nonce using rfc6979. If
// FastSign is passed, then we skip set 14.
// above algorithm. If CustomNonce is used, steps 6-8 follow BIP-340's
// nonce derivation using the provided auxiliary randomness. If CustomNonce
// is NOT used (the default), steps 6-8 are replaced with RFC6979 nonce
// generation for deterministic signing. If FastSign is passed, we skip
// step 14 (signature verification).

// Step 1.
//
Expand Down