Open
Conversation
chatton
requested review from
Wondertan,
renaynay,
vgonkivs and
walldiss
as code owners
chatton
commented
Dec 2, 2025
| secrets: inherit | ||
|
|
||
| # build the compatibility image for use in cross compatibility tests. | ||
| docker-compat-build: |
Collaborator
Author
There was a problem hiding this comment.
we might actually need to move this into the same workflow as the test, so that the tests can depend on this image being built more easily, but that can happen in a followup, I don't want to re-structure workflows too much in this same PR.
chatton
commented
Dec 3, 2025
| return runCompatibilityTests(ctx, client, args.skipGetRow) | ||
| } | ||
|
|
||
| func runCompatibilityTests(ctx context.Context, client *rpcclient.Client, skipGetRow bool) error { |
Collaborator
Author
There was a problem hiding this comment.
I didn't make modifications to this, if anyone on the node team has more compatibility tests in mind, feel free to push to this branch or let me know what else needs to be tested. I was mainly focusing on how the image will be built and then how it will be utilized in future PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the compatibility testing binary that was being introduced in this PR #4680
By adding it in a single PR, we can more easily backport it to any branch that needs it.
For more context on its purpose see #4680 (review)