updated navbar styles and added home link#131
updated navbar styles and added home link#131ChrisDietrich405 wants to merge 3 commits intocivictechdc:mainfrom
Conversation
|
Hey @ChrisDietrich405 -- sorry that I'm just now seeing this PR. I'll add it to my list to review it <3 |
|
Ok. No problem at all. I hope you like my potential edits. Have a great day!
…On Sat, Jan 18, 2025 at 4:22 PM Sheldon Bachstein ***@***.***> wrote:
Hey @ChrisDietrich405 <https://github.com/ChrisDietrich405> -- sorry that
I'm just now seeing this PR. I'll add it to my list to review it <3
—
Reply to this email directly, view it on GitHub
<#131 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQ2EF3UB2ELOXLD6KN7EYL32LLAZ3AVCNFSM6AAAAABRE4RTFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJZHE4TGOJWGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
*Chris Dietrich*
*Whatsapp: 240 814 4208*
*Yahoo mail: ***@***.*** ***@***.***> *
|
sheldon-b
left a comment
sheldon-b
left a comment
There was a problem hiding this comment.
I like the addition of the hero image but I have questions/feedback on the other changes
Can you please merge in latest main, run npm run lint to normalize the formatting, and address the comments I made? Thanks!
| <ul class="usa-nav__primary usa-accordion"> | ||
| <li class="usa-nav__primary-item"> | ||
| <a class="usa-nav__link" href="{{ site.baseurl }}/"> | ||
| <span>Home</span> |
There was a problem hiding this comment.
I like the addition of the home page to the menu 👍
| </a> | ||
| </div> | ||
| <button type="button" class="usa-menu-btn">Menu</button> | ||
| <button type="button" id="navbar-hamburger-menu" class="usa-menu-btn">Menu</button> |
There was a problem hiding this comment.
Can you please explain what the intention here is and how to test it? I checked out this branch and couldn't visually see the 10px right margin. Perhaps a before/after screenshot?
| .ctdc_logo>img { | ||
| max-height: 4rem; |
There was a problem hiding this comment.
This makes the too small. I prefer to keep it at 8rem
Perhaps we should align the menu lower with the top of the hero image instead of centered between the top of the screen and the hero image
2 participants
This PR introduces a few improvements focused on improving the user experience and accessibility of the site. The changes include:
Logo Size Reduction: Reduced the logo size to improve overall page aesthetics
Added Home Link for Accessibility: Introduced a home link to improve navigation for users relying on screen readers, ensuring better accessibility.
Margin Adjustment for Mobile Hamburger Menu: Added a small margin-right to the hamburger menu on mobile to create better spacing and improve touch usability.