Skip to content

updated navbar styles and added home link #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChrisDietrich405 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

updated navbar styles and added home link #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff1691e
updated navbar styles and added home link
ChrisDietrich405 Nov 4, 2024
fffa585
deleted unnecessary id
ChrisDietrich405 Nov 4, 2024
bfe98ab
Merge branch 'main' into main
sheldon-b Jan 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions _includes/components/hero-image.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
<div
class="hero-image grid-col-12"
style="background-image: url({{include.image}})"
>
<div class="hero-image grid-col-12" style="background-image: url({{include.image}})">
<div class="grid-col-12 margin-top-3 margin-left-3 desktop:margin-left-15">
<div class="hero-text padding-2 desktop:margin-left-15">
{% if include.title %}
Expand All @@ -10,4 +7,4 @@ <h1 class="margin-top-0">{{include.title}}</h1>
<p>{{ include.subtitle }}</p>
</div>
</div>
</div>
</div>
9 changes: 7 additions & 2 deletions _includes/core/header.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,18 @@
/>
</a>
</div>
<button type="button" class="usa-menu-btn">Menu</button>
<button type="button" id="navbar-hamburger-menu" class="usa-menu-btn">Menu</button>
Copy link
Member

@sheldon-b sheldon-b Jan 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please explain what the intention here is and how to test it? I checked out this branch and couldn't visually see the 10px right margin. Perhaps a before/after screenshot?

</div>
<nav aria-label="Primary navigation" class="usa-nav">
<button type="button" class="usa-nav__close">
<img src="/assets/img/usa-icons/close.svg" role="img" alt="Close" />
</button>
<ul class="usa-nav__primary usa-accordion">
<li class="usa-nav__primary-item">
<a class="usa-nav__link" href="{{ site.baseurl }}/">
<span>Home</span>
Copy link
Member

@sheldon-b sheldon-b Jan 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the addition of the home page to the menu 👍

</a>
</li>
<li class="usa-nav__primary-item">
<a class="usa-nav__link" href="{{ site.baseurl }}/partners">
<span>Partners</span>
Expand Down Expand Up @@ -51,4 +56,4 @@
</ul>
</nav>
</div>
</header>
</header>
2 changes: 1 addition & 1 deletion assets/css/styles.css
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion assets/css/styles.css.map
View file
Open in desktop

Large diffs are not rendered by default.

11 changes: 8 additions & 3 deletions sass/custom/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,16 @@ body {
flex-shrink: 0;
}


.ctdc_logo > img {
padding-top: 0.5rem;
padding-bottom: 0.5rem;
max-height: 4rem;
}

@media only screen and (min-width: 1024px) {
.ctdc_logo > img {
max-height: 8rem;
.ctdc_logo>img {
max-height: 4rem;
Comment on lines +18 to +19
Copy link
Member

@sheldon-b sheldon-b Jan 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes the too small. I prefer to keep it at 8rem

Perhaps we should align the menu lower with the top of the hero image instead of centered between the top of the screen and the hero image

}
}

Expand Down Expand Up @@ -49,6 +50,10 @@ body {
opacity: 0.75;
}

#navbar-hamburger-menu {
margin-right: 10px;
}

@media only screen and (min-width: 1024px) {
.hero-text {
width: 35%;
Expand All @@ -62,4 +67,4 @@ body {

.usa-header--basic .usa-nav-container {
align-items: center;
}
}