remove deprecated TIMEOUT parameter from tasks#3100
Open
robnester-rh wants to merge 1 commit intoconforma:mainfrom
Open
remove deprecated TIMEOUT parameter from tasks#3100robnester-rh wants to merge 1 commit intoconforma:mainfrom
robnester-rh wants to merge 1 commit intoconforma:mainfrom
Conversation
This commit removes the deprecated TIMEOUT task parameter from the following tasks: - `verify-conforma-konflux-ta` - `verify-conforma-konflux-vsa-ta` - `verify-enterprise-contract` This commit also updates the associated documentation and README files. Ref: EC-1425 Signed-off-by: Rob Nester <rnester@redhat.com>
Contributor
Review Summary by QodoRemove deprecated TIMEOUT parameter from Tekton tasks
WalkthroughsDescription• Remove deprecated TIMEOUT parameter from three Tekton tasks • Update task YAML definitions to remove parameter declaration • Update documentation and README files accordingly Diagramflowchart LR
A["Three Tekton Tasks"] -->|Remove TIMEOUT param| B["Task YAML Files"]
A -->|Remove TIMEOUT docs| C["Documentation Files"]
B --> D["Updated Task Definitions"]
C --> E["Updated Documentation"]
File Changes1. tasks/verify-conforma-konflux-ta/0.1/verify-conforma-konflux-ta.yaml
|
Contributor
Code Review by Qodo
1. TIMEOUT param breaking removal
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
| description: Merge additional Rego variables into the policy data. Use syntax "key=value,key2=value2..." | ||
| default: "" | ||
|
|
||
| - name: TIMEOUT |
Contributor
There was a problem hiding this comment.
1. Timeout param breaking removal 🐞 Bug ⛯ Reliability
• The PR removes the (deprecated) TIMEOUT param from the v0.1 Tekton Task specs, which is a backwards-incompatible contract change for any existing TaskRun/PipelineRun still providing TIMEOUT. • Because the tasks remain versioned as 0.1 and are used directly for bundle creation, this change ships “in place” rather than via a new task version, increasing upgrade risk for downstream users.
Agent Prompt
## Issue description
The deprecated `TIMEOUT` Tekton param was removed from multiple `0.1` task specs. Even if it was ignored at runtime, removing it from the spec is a breaking interface change for any PipelineRun/TaskRun still passing `TIMEOUT`.
## Issue Context
These tasks are bundled/published by reading the `tasks/.../0.1/*.yaml` files directly, so changing `0.1` in-place changes what downstream users consume.
## Fix Focus Areas
- tasks/verify-enterprise-contract/0.1/verify-enterprise-contract.yaml[119-131]
- tasks/verify-conforma-konflux-ta/0.1/verify-conforma-konflux-ta.yaml[112-126]
- tasks/verify-conforma-konflux-vsa-ta/0.1/verify-conforma-konflux-vsa-ta.yaml[123-139]
- docs/modules/ROOT/pages/release-process.adoc[93-103]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the deprecated TIMEOUT task parameter from the following tasks:
verify-conforma-konflux-taverify-conforma-konflux-vsa-taverify-enterprise-contractThis commit also updates the associated documentation and README files.
Ref: EC-1425