Skip to content

remove deprecated TIMEOUT parameter from tasks #3100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robnester-rh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

remove deprecated TIMEOUT parameter from tasks #3100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions docs/modules/ROOT/pages/verify-conforma-konflux-ta.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,6 @@ paths can be provided by using the `:` separator.
+
*Default*: `now`
*EXTRA_RULE_DATA* (`string`):: Merge additional Rego variables into the policy data. Use syntax "key=value,key2=value2..."
*TIMEOUT* (`string`):: This param is deprecated and will be removed in future. Its value is ignored. EC will be run without a timeout. (If you do want to apply a timeout use the Tekton task timeout.)

*WORKERS* (`string`):: Number of parallel workers to use for policy evaluation.

+
Expand Down
2 changes: 0 additions & 2 deletions docs/modules/ROOT/pages/verify-conforma-vsa-release-ta.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,6 @@ registries/Rekor. Multiple paths can be provided using `:`.
*Default*: `now`
*EXTRA_RULE_DATA* (`string`):: Merge additional Rego variables into the policy data. Syntax: key=val,key2=val2

*TIMEOUT* (`string`):: Deprecated; ignored by the task. EC is run without a timeout (use Tekton timeouts).

*WORKERS* (`string`):: Number of parallel workers to use for policy evaluation.
+
*Default*: `4`
Expand Down
2 changes: 0 additions & 2 deletions docs/modules/ROOT/pages/verify-enterprise-contract.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,6 @@ paths can be provided by using the `:` separator.
+
*Default*: `now`
*EXTRA_RULE_DATA* (`string`):: Merge additional Rego variables into the policy data. Use syntax "key=value,key2=value2..."
*TIMEOUT* (`string`):: This param is deprecated and will be removed in future. Its value is ignored. EC will be run without a timeout. (If you do want to apply a timeout use the Tekton task timeout.)

*WORKERS* (`string`):: Number of parallel workers to use for policy evaluation.
+
*Default*: `1`
Expand Down
1 change: 0 additions & 1 deletion tasks/verify-conforma-konflux-ta/0.1/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ kubectl apply -f https://raw.githubusercontent.com/conforma/cli/main/tasks/verif
* **HOMEDIR**: Value for the HOME environment variable. (default: "/tekton/home")
* **EFFECTIVE_TIME**: Run policy checks with the provided time. (default: "now")
* **EXTRA_RULE_DATA**: Merge additional Rego variables into the policy data. Use syntax "key=value,key2=value2..." (default: "")
* **TIMEOUT**: This param is deprecated and will be removed in future. Its value is ignored. EC will be run without a timeout. (If you do want to apply a timeout use the Tekton task timeout.) (default: "")
* **WORKERS**: Number of parallel workers to use for policy evaluation. This parameter is currently not used. All policy evaluations are run with 35 workers. (default: "35")
* **SINGLE_COMPONENT**: Reduce the Snapshot to only the component whose build caused the Snapshot to be created (default: "false")
* **SINGLE_COMPONENT_CUSTOM_RESOURCE**: Name, including kind, of the Kubernetes resource to query for labels when single component mode is enabled, e.g. pr/somepipeline. (default: "unknown")
Expand Down
7 changes: 0 additions & 7 deletions tasks/verify-conforma-konflux-ta/0.1/verify-conforma-konflux-ta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,13 +118,6 @@ spec:
description: Merge additional Rego variables into the policy data. Use syntax "key=value,key2=value2..."
default: ""

- name: TIMEOUT
type: string
description: >
This param is deprecated and will be removed in future. Its value is ignored. EC will
be run without a timeout. (If you do want to apply a timeout use the Tekton task timeout.)
default: ""

- name: WORKERS
type: string
description: >
Expand Down
7 changes: 0 additions & 7 deletions tasks/verify-conforma-konflux-vsa-ta/0.1/verify-conforma-konflux-vsa-ta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,13 +132,6 @@ spec:
key=val,key2=val2
default: ""

- name: TIMEOUT
type: string
description: >
Deprecated; ignored by the task. EC is run without a timeout (use
Tekton timeouts).
default: ""

- name: WORKERS
type: string
description: Number of parallel workers to use for policy evaluation.
Expand Down
1 change: 0 additions & 1 deletion tasks/verify-enterprise-contract/0.1/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ kubectl apply -f https://raw.githubusercontent.com/conforma/cli/main/tasks/verif
* **HOMEDIR**: Value for the HOME environment variable. (default: "/tekton/home")
* **EFFECTIVE_TIME**: Run policy checks with the provided time. (default: "now")
* **EXTRA_RULE_DATA**: Merge additional Rego variables into the policy data. Use syntax "key=value,key2=value2..." (default: "")
* **TIMEOUT**: This param is deprecated and will be removed in future. Its value is ignored. EC will be run without a timeout. (If you do want to apply a timeout use the Tekton task timeout.) (default: "")
* **WORKERS**: Number of parallel workers to use for policy evaluation. (default: "1")
* **SINGLE_COMPONENT**: Reduce the Snapshot to only the component whose build caused the Snapshot to be created (default: "false")
* **SINGLE_COMPONENT_CUSTOM_RESOURCE**: Name, including kind, of the Kubernetes resource to query for labels when single component mode is enabled, e.g. pr/somepipeline. (default: "unknown")
Expand Down
7 changes: 0 additions & 7 deletions tasks/verify-enterprise-contract/0.1/verify-enterprise-contract.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,13 +125,6 @@ spec:
description: Merge additional Rego variables into the policy data. Use syntax "key=value,key2=value2..."
default: ""

- name: TIMEOUT
Copy link
Contributor

@qodo-code-review qodo-code-review bot Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Timeout param breaking removal 🐞 Bug ⛯ Reliability

• The PR removes the (deprecated) TIMEOUT param from the v0.1 Tekton Task specs, which is a
  backwards-incompatible contract change for any existing TaskRun/PipelineRun still providing TIMEOUT.
• Because the tasks remain versioned as 0.1 and are used directly for bundle creation, this change
  ships “in place” rather than via a new task version, increasing upgrade risk for downstream users.
Agent Prompt 
## Issue description
The deprecated `TIMEOUT` Tekton param was removed from multiple `0.1` task specs. Even if it was ignored at runtime, removing it from the spec is a breaking interface change for any PipelineRun/TaskRun still passing `TIMEOUT`.

## Issue Context
These tasks are bundled/published by reading the `tasks/.../0.1/*.yaml` files directly, so changing `0.1` in-place changes what downstream users consume.

## Fix Focus Areas
- tasks/verify-enterprise-contract/0.1/verify-enterprise-contract.yaml[119-131]
- tasks/verify-conforma-konflux-ta/0.1/verify-conforma-konflux-ta.yaml[112-126]
- tasks/verify-conforma-konflux-vsa-ta/0.1/verify-conforma-konflux-vsa-ta.yaml[123-139]
- docs/modules/ROOT/pages/release-process.adoc[93-103]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

type: string
description: >
This param is deprecated and will be removed in future. Its value is ignored. EC will
be run without a timeout. (If you do want to apply a timeout use the Tekton task timeout.)
default: ""

- name: WORKERS
type: string
description: Number of parallel workers to use for policy evaluation.
Expand Down
Loading