Backward compatibility for subset get_element_names#1338
Open
cubewise-gng wants to merge 6 commits intocubewise-code:masterfrom
Open
Backward compatibility for subset get_element_names#1338cubewise-gng wants to merge 6 commits intocubewise-code:masterfrom
cubewise-gng wants to merge 6 commits intocubewise-code:masterfrom
Conversation
MariusWirtz
added
the
release:patch
MariusWirtz
reviewed
Feb 3, 2026
TM1py/Services/SubsetService.py
Outdated
| """ | ||
| # backward compatibility for subset_name | ||
| if "subset_name" in kwargs: | ||
| subset = kwargs["subset_name"] |
Collaborator
There was a problem hiding this comment.
@cubewise-gng
please do another check to verify if subset and subet_name are both provided. In that case we can raise a ValuError
MariusWirtz
reviewed
Feb 3, 2026
| @@ -201,7 +201,7 @@ def delete_elements_from_static_subset( | |||
| return self._rest.DELETE(url=url, **kwargs) | |||
|
|
|||
| def get_element_names( | |||
Collaborator
There was a problem hiding this comment.
Please add some test cases of possible argument combinations here Tests/SubsetService_test.py
Collaborator
|
Thanks for the fix! Please implement the two requested enhancements and rebase on the current master branch |
- harmonize CONTRIBUTING.md & docs/how-to-contribute.md - remove networkx from pyproject.toml
Contributor
Author
|
Hi @MariusWirtz, added the requested changes. Hope I did the rebase correctly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1302 get_element_names in SubsetService not backwards compatible