Skip to content

Backward compatibility for subset get_element_names #1338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cubewise-gng wants to merge 6 commits into from
Closed

Backward compatibility for subset get_element_names #1338

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
09b5915
Backward compatibility for subset get_element_names
cubewise-gng Jan 30, 2026
9c33c71
added semantic versioning and automated releases
nicolasbisurgi Nov 20, 2025
64de0bd
Adapt auto release to rebase & merge strategy
MariusWirtz Jan 30, 2026
a318dfb
Apply Black and Ruff formatting across project
MariusWirtz Jan 30, 2026
47fb2c1
Micro Release implement copilot feedback
MariusWirtz Jan 30, 2026
aab3ecf
Added testcase and argument check
cubewise-gng Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion TM1py/Services/SubsetService.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ def delete_elements_from_static_subset(
return self._rest.DELETE(url=url, **kwargs)

def get_element_names(
Copy link
Collaborator

@MariusWirtz MariusWirtz Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some test cases of possible argument combinations here Tests/SubsetService_test.py

self, dimension_name: str, hierarchy_name: str, subset: Union[str, Subset], private: bool = False, **kwargs
self, dimension_name: str, hierarchy_name: str, subset: Union[str, Subset] = None, private: bool = False, **kwargs
) -> List[str]:
"""
Retrieve element names from a static or dynamic subset.
Expand All @@ -213,6 +213,10 @@ def get_element_names(
:param kwargs: Additional arguments.
:return: List of element names.
"""
# backward compatibility for subset_name
if "subset_name" in kwargs:
subset = kwargs["subset_name"]
Copy link
Collaborator

@MariusWirtz MariusWirtz Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cubewise-gng
please do another check to verify if subset and subet_name are both provided. In that case we can raise a ValuError


if isinstance(subset, str):
subset = self.get(subset, dimension_name, hierarchy_name, private=private, **kwargs)
elif not isinstance(subset, Subset):
Expand Down