Open
Conversation
This test demonstrates the bug where cookies with the #HttpOnly_ prefix are incorrectly ignored. According to the Netscape cookie file format specification, lines starting with #HttpOnly_ should be parsed as cookies with the HttpOnly attribute set. See: https://curl.se/docs/http-cookies.html Currently fails: Expected 3 cookies (2 httponly + 1 regular) but only finds 1 (the regular cookie).
Parse cookies with #HttpOnly_ prefix according to the Netscape cookie file format specification. Previously, all lines starting with # were treated as comments, but lines starting with #HttpOnly_ indicate cookies with the HttpOnly attribute set. The fix: - Detects #HttpOnly_ prefix and strips it before parsing - Adds httponly attribute to the cookie string - Continues to treat regular # lines as comments See: https://curl.se/docs/http-cookies.html Fixes dantleech#133
dantleech
reviewed
Feb 6, 2026
| ; | ||
|
|
||
| $path = $this->workspace()->path('httponly_cookies.txt'); | ||
| file_put_contents($path, $cookies); |
Owner
There was a problem hiding this comment.
You can simplify this to $this->workspace()->put('httponly_cookies.txt', $cookies)
Owner
|
👍 just a minor improvement on the teset |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #133
Adds support for parsing cookies with
#HttpOnly_prefix according to the Netscape cookie file format specification.See: https://curl.se/docs/http-cookies.html