Skip to content

Support parsing httponly cookies #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aszenz wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support parsing httponly cookies #135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61c2033
Add test case for httponly cookie parsing
aszenz Feb 6, 2026
f6764eb
Fix parsing of httponly cookies
aszenz Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion lib/Adapter/Artax/NetscapeCookieFileJar.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,14 @@ private function parse(string $line): ?ResponseCookie
return null;
}

if ($line[0] === '#') {
// Handle httponly cookies - lines starting with #HttpOnly_ should be parsed
// See: https://curl.se/docs/http-cookies.html
$isHttpOnly = false;
if (str_starts_with($line, '#HttpOnly_')) {
$line = substr($line, 10); // Remove the '#HttpOnly_' prefix
$isHttpOnly = true;
} elseif ($line[0] === '#') {
// Regular comment line, skip it
return null;
}

Expand Down Expand Up @@ -104,6 +111,10 @@ private function parse(string $line): ?ResponseCookie
$string .= '; secure';
}

if ($isHttpOnly) {
$string .= '; httponly';
}

return ResponseCookie::fromHeader($string);
}
}
37 changes: 37 additions & 0 deletions tests/Integration/Adapter/Artax/NetscapeCookieFileJarTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,4 +71,41 @@ public function testLoadCookies()
(yield $jar->get((new Request('http://127.0.0.1/'))->getUri()))[0]->getValue()
);
}

public function testLoadHttpOnlyCookies()
{
$expire = (new DateTimeImmutable())->modify('+1 day')->format('U');

$cookies = <<<EOT
# Netscape HTTP Cookie File
# This is a comment and should be ignored

#HttpOnly_.example.com TRUE / FALSE $expire session_id abc123
#HttpOnly_example.com FALSE /admin TRUE $expire admin_token xyz789
.example.com TRUE / FALSE $expire regular_cookie normal_value
EOT
;

$path = $this->workspace()->path('httponly_cookies.txt');
file_put_contents($path, $cookies);
Copy link
Owner

@dantleech dantleech Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can simplify this to $this->workspace()->put('httponly_cookies.txt', $cookies)


$jar = new NetscapeCookieFileJar($path);

$allCookies = $jar->getAll();

// Should have 3 cookies total (2 httponly + 1 regular)
$this->assertCount(3, $allCookies);

// Get cookies for example.com
$exampleCookies = yield $jar->get((new Request('https://example.com/'))->getUri());

// Should include the httponly cookie
$cookieNames = array_map(fn ($cookie) => $cookie->getName(), $exampleCookies);
$this->assertContains('session_id', $cookieNames);
$this->assertContains('regular_cookie', $cookieNames);

// Verify httponly cookie value
$sessionCookie = array_filter($exampleCookies, fn ($cookie) => $cookie->getName() === 'session_id');
$this->assertEquals('abc123', reset($sessionCookie)->getValue());
}
}
Loading