Close HTTP response bodies to fix bodyclose lint#566
Merged
JamieMagee merged 1 commit intomainfrom Feb 10, 2026
Merged
Conversation
Two spots were missing resp.Body.Close() calls: - update_test.go: the http.Post response was discarded. Now we capture it and close the body before returning. - run.go (checkCredAccess): the response from the GitHub API token-scope check was never closed. Added a defer.
truggeri
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
golangci-lint's
bodyclosechecker flagged two unclosed HTTP response bodies:cmd/dependabot/internal/cmd/update_test.go—http.Postresponse was discarded (_, err := ...). Now we capture the response and callresp.Body.Close()before returning from the retry loop.internal/infra/run.go(checkCredAccess) — the response from the GitHub API token-scope check was never closed. Addeddefer resp.Body.Close()after the error check.