Skip to content

Close HTTP response bodies to fix bodyclose lint #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JamieMagee merged 1 commit into from
Feb 10, 2026
Merged

Close HTTP response bodies to fix bodyclose lint #566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cmd/dependabot/internal/cmd/update_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,10 +295,11 @@ func Test_extractInput(t *testing.T) {
// Retry the calls in case the server takes a bit to start up.
for i := 0; i < 10; i++ {
body := strings.NewReader(`{"job":{"package-manager":"go_modules"}}`)
_, err := http.Post("http://127.0.0.1:8080", "application/json", body)
resp, err := http.Post("http://127.0.0.1:8080", "application/json", body)
if err != nil {
time.Sleep(10 * time.Millisecond)
} else {
resp.Body.Close()
return
}
}
Expand Down
1 change: 1 addition & 0 deletions internal/infra/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,7 @@ func checkCredAccess(ctx context.Context, job *model.Job, creds []model.Credenti
if err != nil {
return fmt.Errorf("failed making request: %w", err)
}
defer resp.Body.Close()
if resp.StatusCode != http.StatusOK {
return fmt.Errorf("failed request to GitHub API to check access: %s", resp.Status)
}
Expand Down