Adding AppliesTo attribute to query providers#9631
Merged
drewnoakes merged 1 commit intodotnet:mainfrom Jan 16, 2025
Merged
Conversation
drewnoakes
approved these changes
Jan 16, 2025
drewnoakes
added
Feature-Debugging
drewnoakes
pushed a commit
that referenced
this pull request
Feb 3, 2025
…ers (#9641) This is a follow up to these PRs: #9621, #9631 The TypeScript/JavaScript team is working on adding a version of the launch profiles UI that reads/writes from` launch.json `rather than` launchsettings.json`. We'd like reuse dotnet's existing functionality for this, with the exception of actions specific to modifying ` launchsettings.json`. With this PR, all actions specific to ` launchsettings.json` have been moved into a separate class (`LaunchProfileProjectActionProvider`) with relevant filtering `([AppliesTo(ProjectCapability.DotNet)])`. I have removed this filtering from the other action providers so they can be used for JSPS projects as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The project team is working on supporting multiple query providers for different project systems. The JavaScript project team aims to add launch profiles action providers. Currently, the issue is that the .NET provider takes precedence, preventing their provider from being invoked. The AppliesTo attribute will be used to select the appropriate provider based on capability. At present, we are not reading this attribute on the query side, so it will not have any impact.
Microsoft Reviewers: Open in CodeFlow