Avoid UUID.randomUUID() in Verticle deployment startup code#5469
Avoid UUID.randomUUID() in Verticle deployment startup code#5469vietj merged 1 commit intoeclipse-vertx:masterfrom
Conversation
This is done because bootstrapping the plumbing needed by the JDK to produce a UUID value is expensive, it thus doesn't make sense to pay this cost when the property isn't actually needed
|
I think for this one we might have a deploymend ID in the deployment options to force a specific ID like we have done for file system path, this provides full control over the ID to quarkus |
|
Makes sense. I'll update the PR next week |
|
Now that I think of it, wouldn't it make more sense for |
actually no, with vertx 5 we want to that Options object are purely data (json) if we need something with a supplier we would go with a builder instead |
|
What builder are you talking about? |
|
@geoand I believe @vietj is talking about the effort we have made in Vert.x 5 to have data objects, well, pure data objects and use builders when non data config is required (see for example vert-x3/vertx-micrometer-metrics#229) Anyway, we don't need anything from |
|
🙏🏽 |
|
@geoand sorry for the lack of context :-), indeed @tsegismont gave the context |
|
thank you @geoand |
|
🙏🏽 |
This is done because bootstrapping the plumbing
needed by the JDK to produce a UUID value
is expensive, it thus doesn't make sense to
pay this cost when the property isn't actually
needed
As requested in #5450 (comment)