Skip to content

Avoid UUID.randomUUID() in Verticle deployment startup code #5469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vietj merged 1 commit into from
Feb 11, 2025
Merged

Avoid UUID.randomUUID() in Verticle deployment startup code #5469

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion vertx-core/src/main/java/io/vertx/core/impl/deployment/DefaultDeploymentManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

import java.util.*;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.atomic.AtomicLong;

/**
* @author <a href="http://tfox.org">Tim Fox</a>
Expand All @@ -27,6 +28,8 @@ public class DefaultDeploymentManager implements DeploymentManager {

public static final Logger log = LoggerFactory.getLogger(DefaultDeploymentManager.class);

private static final AtomicLong nextId = new AtomicLong();

private final VertxImpl vertx;
private final Map<String, DeploymentContext> deploying = new HashMap<>();
private final Map<String, DeploymentContext> deployments = new ConcurrentHashMap<>();
Expand All @@ -36,7 +39,11 @@ public DefaultDeploymentManager(VertxImpl vertx) {
}

private String generateDeploymentID() {
return UUID.randomUUID().toString();
if (vertx.isClustered() && vertx.haManager()!=null) {
// in this case we need a globally unique id
return UUID.randomUUID().toString();
}
return Long.valueOf(nextId.incrementAndGet()).toString();
}

public Future<Void> undeploy(String deploymentID) {
Expand Down
Loading