Open
Conversation
9 tasks
|
PR missing one of the required labels: {'breaking-change', 'documentation', 'enhancement', 'bug', 'new feature', 'internal', 'api-sync', 'dependencies', 'ci'} |
Remove deprecated setPriority(DATA_HIGH) and setCongestionControl(DROP) calls from queryReplySuccessTest, and update assertions to expect the default values (Priority.DATA, CongestionControl.BLOCK) since the JNI layer now ignores user-set QoS parameters on replies. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
milyin
force-pushed
the
zbobr_fix-31-set-prep-params
branch
2 times, most recently
from
9fc6d90 to
9943d98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for #428
implemented with milyin-zenoh-zbobr/tasks#31