Merged
Conversation
rubo
commented
Jan 15, 2025
Comment on lines
106
to
-118
| - uses: actions/download-artifact@v4 | ||
| with: | ||
| pattern: ckzg-library-wrapper-* | ||
| path: bindings/csharp/Ckzg.Bindings/runtimes/linux-x64/native | ||
| - uses: actions/download-artifact@v4 | ||
| with: | ||
| pattern: ckzg-library-wrapper-* | ||
| path: bindings/csharp/Ckzg.Bindings/runtimes/osx-x64/native | ||
| - uses: actions/download-artifact@v4 | ||
| with: | ||
| pattern: ckzg-library-wrapper-* | ||
| path: bindings/csharp/Ckzg.Bindings/runtimes/win-x64/native | ||
| - uses: actions/download-artifact@v4 | ||
| with: | ||
| pattern: ckzg-library-wrapper-* | ||
| path: bindings/csharp/Ckzg.Bindings/runtimes/osx-arm64/native | ||
| - uses: actions/download-artifact@v4 | ||
| with: | ||
| pattern: ckzg-library-wrapper-* | ||
| path: bindings/csharp/Ckzg.Bindings/runtimes/linux-arm64/native |
Contributor
Author
There was a problem hiding this comment.
These actions were downloading all 5 artifacts 5 times for no reason. Now, it does once and later puts each of them where they should be.
Comment on lines
85
to
+96
| - uses: actions/download-artifact@v4 | ||
| with: | ||
| pattern: 'ckzg-library-wrapper-${{ matrix.target.location }}-*' | ||
| path: bindings/csharp/Ckzg.Bindings/runtimes/${{ matrix.target.location }}/native | ||
| merge-multiple: true | ||
| pattern: ckzg-library-wrapper-* | ||
| path: bindings/csharp/Ckzg.Bindings/runtimes | ||
| - name: Move artifacts | ||
| working-directory: bindings/csharp/Ckzg.Bindings/runtimes | ||
| run: | | ||
| mv ckzg-library-wrapper-linux-arm64/ckzg.so linux-arm64/native/ckzg.so | ||
| mv ckzg-library-wrapper-linux-x64/ckzg.so linux-x64/native/ckzg.so | ||
| mv ckzg-library-wrapper-osx-arm64/ckzg.dylib osx-arm64/native/ckzg.dylib | ||
| mv ckzg-library-wrapper-osx-x64/ckzg.dylib osx-x64/native/ckzg.dylib | ||
| mv ckzg-library-wrapper-win-x64/ckzg.dll win-x64/native/ckzg.dll |
Contributor
Author
There was a problem hiding this comment.
Since the checks have been removed from the .csproj file, we need to ensure that each artifact is present even though it is not used on the platform being run.
jtraglia
approved these changes
Jan 15, 2025
Member
jtraglia
left a comment
jtraglia
left a comment
There was a problem hiding this comment.
This looks great. Thanks for the other updates too!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #528
runtimesdirectory in the.csprojfile to fail the build when those files are missing