Add support for temporal mesh in vtkF3DMemoryMesh and scene API#2561
Open
0xfedcafe wants to merge 4 commits intof3d-app:masterfrom
Open
Add support for temporal mesh in vtkF3DMemoryMesh and scene API#25610xfedcafe wants to merge 4 commits intof3d-app:masterfrom
0xfedcafe wants to merge 4 commits intof3d-app:masterfrom
Conversation
|
You are modifying libf3d public API! |
Member
Author
|
\ci fast |
0xfedcafe
force-pushed
the
temporal-mesh-memory
branch
2 times, most recently
from
0454de1 to
a89c03e
Compare
mwestphal
reviewed
Oct 23, 2025
library/public/scene.h
Outdated
| virtual scene& add(const std::filesystem::path& filePath) = 0; | ||
| virtual scene& add(const std::vector<std::filesystem::path>& filePath) = 0; | ||
| virtual scene& add(const std::vector<std::string>& filePathStrings) = 0; | ||
| virtual scene& add(const std::vector<mesh_t>& mesh, double timeStep) = 0; |
Member
There was a problem hiding this comment.
im not sure to follow, why is there multple meshes for a single timestep ?
Member
|
Need any help moving forward @0xfedcafe ? |
0xfedcafe
force-pushed
the
temporal-mesh-memory
branch
from
47433bf to
ff3de6e
Compare
Member
|
Hi @0xfedcafe , still working on this ? |
Member
|
Hi @0xfedcafe , still working on this ? |
Member
Author
|
Hi, I updated things a bit after the redesign of the feature. I'll finish it soon. |
Member
|
Do not hesitate to discuss the API more in deep in discord before implementing anything :) |
0xfedcafe
force-pushed
the
temporal-mesh-memory
branch
2 times, most recently
from
709d651 to
0326221
Compare
0xfedcafe
force-pushed
the
temporal-mesh-memory
branch
from
0326221 to
cb8da47
Compare
mwestphal
reviewed
Dec 22, 2025
Co-authored-by: Mathieu Westphal <mathieu.westphal@gmail.com>
0xfedcafe
force-pushed
the
temporal-mesh-memory
branch
from
40f949d to
0be9b28
Compare
mwestphal
reviewed
Dec 22, 2025
| @@ -307,6 +296,35 @@ scene& scene_impl::add(const std::vector<fs::path>& filePaths) | |||
| } | |||
|
|
|||
| //---------------------------------------------------------------------------- | |||
| scene& scene_impl::add(std::vector<double> times, MeshCallback&& callback) | |||
| { | |||
| if (times[1] < times[0]) | |||
Member
There was a problem hiding this comment.
dont check anything here, let vtkF3DMemnoryMesh handle it
mwestphal
reviewed
Dec 22, 2025
| * using SetPoints, SetNormals, SetTCoords, and SetFaces methods. | ||
| * This switches the mesh to animated mode with the given time range. | ||
| */ | ||
| void SetAnimatedMesh(double startTime, double endTime, MeshCallback callback); |
mwestphal
reviewed
Dec 22, 2025
| this->Internals->Load({ importer }); | ||
| return *this; | ||
| } | ||
|
|
||
| scene& scene_impl::add(const mesh_t& mesh) |
Member
There was a problem hiding this comment.
I think you should be able to call the other method here ?
mwestphal
reviewed
Dec 22, 2025
| * Callback type for animated meshes. | ||
| * Called with the current time value, should return the mesh for that time. | ||
| */ | ||
| using MeshCallback = std::function<mesh_t(double time)>; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add support for temporal mesh in vtkF3DMemoryMesh and scene API. I haven't updated bindings yet as I haven't figured out which was to be updated or how.
Issue ticket number and link if any
#2443 , #2443
Checklist for finalizing the PR
.github/workflows/versions.json, I have updatedtimestampContinuous integration
Please write a comment to run CI, eg:
\ci fast.See here for more info.