Skip PredictableMetricsAnalysis for BatchTrials in OverviewAnalysis#4852
Closed
shrutipatel31 wants to merge 1 commit intofacebook:mainfrom
Closed
Skip PredictableMetricsAnalysis for BatchTrials in OverviewAnalysis#4852shrutipatel31 wants to merge 1 commit intofacebook:mainfrom
shrutipatel31 wants to merge 1 commit intofacebook:mainfrom
Conversation
Summary: Quick fix to avoid calling PredictableMetricsAnalysis for experiments with BatchTrials until we resolve the shape mismatch issue occurring at https://www.internalfb.com/code/fbsource/[76c3cd2940cf480331df8b1d276e608c60b29d3a]/fbcode/ax/utils/stats/model_fit_stats.py?lines=111 Some users have expressed confusion because of the error raised in this healthcheck hence skipping this healthcheck until the we figure proper fix for this. Differential Revision: D92184502
meta-cla
bot
added
the
CLA Signed
|
@shrutipatel31 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D92184502. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4852 +/- ##
=======================================
Coverage 96.75% 96.75%
=======================================
Files 589 589
Lines 61679 61679
=======================================
+ Hits 59677 59678 +1
+ Misses 2002 2001 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request has been merged in b967b03. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Quick fix to avoid calling PredictableMetricsAnalysis for experiments with BatchTrials until we resolve the shape mismatch issue occurring at https://www.internalfb.com/code/fbsource/[76c3cd2940cf480331df8b1d276e608c60b29d3a]/fbcode/ax/utils/stats/model_fit_stats.py?lines=111
Some users have expressed confusion because of the error raised in this healthcheck hence skipping this healthcheck until the we figure proper fix for this.
Differential Revision: D92184502