fix(python): use path= instead of url= for path-based pagination#12334
Merged
aditya-arolkar-swe merged 3 commits intomainfrom Feb 13, 2026
Merged
fix(python): use path= instead of url= for path-based pagination#12334aditya-arolkar-swe merged 3 commits intomainfrom
aditya-arolkar-swe merged 3 commits intomainfrom
Conversation
Co-Authored-By: adi@buildwithfern.com <aditya.arolkar@berkeley.edu>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
tjb9dc
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refs #12238
Fixes a bug introduced in #12238 where path-based pagination passes the next page path as
url=instead ofpath=in the generated_fetch_next_pagefunction. The wrapper'sHttpClient.request()method has nourlparameter — its signature isrequest(path=None, *, method, base_url=None, ...)— sourl=_next_pathwould raise aTypeErrorat runtime.Changes Made
url=_next_path→path=_next_pathinPathPagination.init_get_next()so the generated code correctly callsself._client_wrapper.httpx_client.request(method="GET", path=_next_path), which combines the path with the default base URL via_build_url()pagination-uri-pathseed snapshot (both sync and async clients)Note: URI pagination (
uri.py) correctly usesbase_url=_next_urland is not affected.Testing
pagination-uri-pathfixtureReview Checklist
path=matches theHttpClient.request()/AsyncHttpClient.request()signature ingenerators/python/core_utilities/shared/http_client.pyurl=_next_path(only the one fixture was affected)Link to Devin run: https://app.devin.ai/sessions/4d78e393305e45d3b89d8cb8535aa00b
Requested by: @aditya-arolkar-swe