Skip to content

fix(python): use path= instead of url= for path-based pagination #12334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aditya-arolkar-swe merged 3 commits into from
Feb 13, 2026
Merged

fix(python): use path= instead of url= for path-based pagination #12334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a01819
fix(python): use path= instead of url= for path-based pagination
devin-ai-integration[bot] Feb 13, 2026
dcbf496
Update versions.yml
aditya-arolkar-swe Feb 13, 2026
b660cb7
Merge branch 'main' into devin/1771000193-fix-path-pagination-url
aditya-arolkar-swe Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions generators/python/sdk/versions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
# yaml-language-server: $schema=../../../fern-versions-yml.schema.json
# For unreleased changes, use unreleased.yml
- version: 4.57.2
changelogEntry:
- summary: |
Fix path-based pagination to pass the next page path as `path=` instead of `url=`
in the generated HTTP client request call.
type: fix
createdAt: "2026-02-13"
irVersion: 65

- version: 4.57.1
changelogEntry:
- summary: |
Expand Down
2 changes: 1 addition & 1 deletion generators/python/src/fern_python/generators/sdk/client_generator/pagination/path.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ def init_get_next(self, *, writer: AST.NodeWriter) -> None:
writer.write(f"{PathPagination.NEXT_RESPONSE_VAR} = await {client_ref}.request(")
else:
writer.write(f"{PathPagination.NEXT_RESPONSE_VAR} = {client_ref}.request(")
writer.write(f'method="{self._http_method}", url=_next_path')
writer.write(f'method="{self._http_method}", path=_next_path')
writer.write_line(")")

# Parse response
Expand Down
4 changes: 2 additions & 2 deletions seed/python-sdk/pagination-uri-path/src/seed/users/raw_client.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading