feat(payment): rollout on hashMapAnnotations change

[Dav-14]

No description provided.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Function signatures for temporalEnvVars and v3EnvVars were changed to return a resource-hash map in addition to env vars and error. Call sites (including createV3Deployment and finalizer) were updated to accept the three-value returns; the hash map is injected into Deployment annotations.

Changes

Cohort / File(s)	Summary
Payments deployment logic internal/resources/payments/deployments.go	Changed temporalEnvVars and v3EnvVars signatures to (map[string]string, []corev1.EnvVar, error). Both functions now accumulate resource reference hashes into a map, assemble Temporal/broker/TLS env vars, and propagate the map. Error-return sites switched to named/bare returns in several paths. createV3Deployment now receives the hash map and sets it on Deployment ObjectMeta.Annotations.
Finalizer call site internal/resources/payments/finalizer.go	Updated call to temporalEnvVars to unpack the new three-value return (_, env, err := temporalEnvVars(...)), preserving existing error handling and env usage.

Sequence Diagram(s)

sequenceDiagram
    participant Controller
    participant v3EnvVars
    participant temporalEnvVars
    participant Secrets
    participant K8sDeployment

    Controller->>v3EnvVars: request envs and hashes (stack, payments, database)
    v3EnvVars->>temporalEnvVars: request temporal envs and resource hashes
    temporalEnvVars->>Secrets: fetch Temporal TLS / encryption key / secrets
    Secrets-->>temporalEnvVars: secret data (or not found)
    temporalEnvVars-->>v3EnvVars: return (hashMap, envVars, err)
    v3EnvVars-->>Controller: return (hashMap, envVars, err)
    Controller->>K8sDeployment: create/update Deployment with envVars and annotations=hashMap
    K8sDeployment-->>Controller: Deployment applied

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Poem

🐰 I hopped through hashes, envs, and keys so bright,
I stitched them to deployments in the night,
Three values returned where once two did roam,
Annotations now carry a warm, hashed home.

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	❓ Inconclusive	No description was provided by the author, making it impossible to evaluate relevance to the changeset.	Add a pull request description explaining the purpose and impact of the hashMapAnnotations change.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: implementing hash map annotations for payment processing rollout.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feat/configure_hash_map_for_payment_v3

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@internal/resources/payments/deployments.go`:
- Around line 54-62: The code dereferences ref (accessing ref.Name and
ref.Status.Hash) before checking err; change the flow in the temporalURI
handling to check the error returned from resourcereferences.Create immediately
and only access ref when err == nil and ref != nil (e.g., call
resourcereferences.Create into ref, err, then if err != nil return the error,
else set hash[ref.Name] = ref.Status.Hash); apply the same immediate-error-check
pattern to the second Create call later in this block and ensure that after
calling resourcereferences.Delete you also handle its error before proceeding.

[Dav-14]

Add the resource Ref to the hashMap.

resourceRef.Create does a CreateOrUpdate and keep the actual resource ref.

[Dav-14]

THen adding it to the podspec