Skip to content

Conversation

@Smkingsize
Copy link
Contributor

@Smkingsize Smkingsize commented Feb 12, 2026

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

There are two labels that allow to ignore specific (false positive) tool linter errors:

  • skip-version-check: Use it if only a subset of the tools has been updated in a suite.
  • skip-url-check: Use it if github CI sees 403 errors, but the URLs work.

@Smkingsize
Copy link
Contributor Author

should I pump the version of the failed tools in the collection?

@SaimMomin12
Copy link
Contributor

should I pump the version of the failed tools in the collection?

No, thats not needed

@bernt-matthias bernt-matthias added the skip-version-check Allow IUC members to skip the version linter in PR reviews (use only for partially updated suites). label Feb 12, 2026
<inputs>
<param name="input" type="data" format="sam,bam,cram" label="Input File"/>
<section name="advanced_options" title="Advanced Options" expanded="no">
<param name="add_pg" type="boolean" label="Add @PG in Header" checked="true" truevalue="" falsevalue="--no-PG" help="Add a @PG line to the header of the output file. "/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use argument

<param name="input" type="data" format="sam,bam,cram" label="Input File"/>
<section name="advanced_options" title="Advanced Options" expanded="no">
<param name="add_pg" type="boolean" label="Add @PG in Header" checked="true" truevalue="" falsevalue="--no-PG" help="Add a @PG line to the header of the output file. "/>
<param name="tmp_files" type="integer" label="Number of temporary files" value="64" min="0" help="Number of temporary files to use. "/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this parameter. Not sure if a user should be able to control this. At least we should set a limit

</param>
<when value="no"></when>
<when value="-f">
<param name="num_reads" type="integer" label="Number of Stored Reads" min="0" value="10000" help="Number of reads to store in memory (for use in fast mode)"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as for tmp_files. Then we also save the conditional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-version-check Allow IUC members to skip the version linter in PR reviews (use only for partially updated suites).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants