-
Notifications
You must be signed in to change notification settings - Fork 501
Add Samtools Collate #7674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Samtools Collate #7674
Conversation
|
should I pump the version of the failed tools in the collection? |
No, thats not needed |
| <inputs> | ||
| <param name="input" type="data" format="sam,bam,cram" label="Input File"/> | ||
| <section name="advanced_options" title="Advanced Options" expanded="no"> | ||
| <param name="add_pg" type="boolean" label="Add @PG in Header" checked="true" truevalue="" falsevalue="--no-PG" help="Add a @PG line to the header of the output file. "/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use argument
| <param name="input" type="data" format="sam,bam,cram" label="Input File"/> | ||
| <section name="advanced_options" title="Advanced Options" expanded="no"> | ||
| <param name="add_pg" type="boolean" label="Add @PG in Header" checked="true" truevalue="" falsevalue="--no-PG" help="Add a @PG line to the header of the output file. "/> | ||
| <param name="tmp_files" type="integer" label="Number of temporary files" value="64" min="0" help="Number of temporary files to use. "/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove this parameter. Not sure if a user should be able to control this. At least we should set a limit
| </param> | ||
| <when value="no"></when> | ||
| <when value="-f"> | ||
| <param name="num_reads" type="integer" label="Number of Stored Reads" min="0" value="10000" help="Number of reads to store in memory (for use in fast mode)"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as for tmp_files. Then we also save the conditional
FOR CONTRIBUTOR:
There are two labels that allow to ignore specific (false positive) tool linter errors:
skip-version-check: Use it if only a subset of the tools has been updated in a suite.skip-url-check: Use it if github CI sees 403 errors, but the URLs work.