Conversation
|
Integration tests report: appsharing.space |
|
I think this actually wouldn't close #1119, since that bug happens outside of a test context. But fixing the test flakiness is still good :) Could you provide some background on why this fixes the test flakiness? 🤔 Would fixing the underlying but #1119 also fix the flaky test? If the flaky test is telling us about a bug, I think I'd rather not address the flakiness and instead address the bug. That way if the bug ever regresses, we'll know because the test will become flaky again. What do you think? |
|
This doesn’t fix #1119 itself, but it fixes test flakiness. Previously we only closed activities between tests, which resets the UI but not the underlying JupyterGIS document. Since all tests reopened the same Re-uploading the |
martinRenou
left a comment
There was a problem hiding this comment.
Thanks! waitForTimeout(1000) is bound to generate flakyness, happy that it's removed
Description
This PR updates the
beforeEachfunction inui-tests/tests/contextmenu.spec.tsto delete and upload a new document before each test. So this removes the flakiness of the test as discussed in #1119 (comment)Checklist
Resolves #XXX.Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lint📚 Documentation preview: https://jupytergis--1121.org.readthedocs.build/en/1121/
💡 JupyterLite preview: https://jupytergis--1121.org.readthedocs.build/en/1121/lite