Create layers by path or external URL with separate fields#335
Merged
martinRenou merged 9 commits intogeojupyter:mainfrom Jan 16, 2025
Merged
Create layers by path or external URL with separate fields#335martinRenou merged 9 commits intogeojupyter:mainfrom
martinRenou merged 9 commits intogeojupyter:mainfrom
Conversation
Contributor
|
|
Meriem-BenIsmail
force-pushed
the
geojson-path-selection
branch
from
25930cf to
22e2a51
Compare
Contributor
|
Integration tests report: appsharing.space |
Collaborator
|
Probably related to the first item of #33 |
Member
Author
6 tasks
Meriem-BenIsmail
force-pushed
the
geojson-path-selection
branch
from
36271c8 to
6362319
Compare
switch between form and file dialog/ filepath modified relative path file name changed reopen the creation dialog if filedialog cancel button is clicked.
Meriem-BenIsmail
force-pushed
the
geojson-path-selection
branch
from
1871a97 to
34ae884
Compare
mfisher87
changed the title
HaudinFlorence
pushed a commit
to HaudinFlorence/jupytergis
that referenced
this pull request
Jan 28, 2026
* use filedialog of jupyterlab for path selection. switch between form and file dialog/ filepath modified relative path file name changed reopen the creation dialog if filedialog cancel button is clicked. * lint * add id for path input * path id * lint * file path id added to the right input * remove geojson form filedialog title to make it more general. * changed image url to image path. * independant local/external file field values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #248.
This PR adds a new widget for path fields where it uses the FileDialog of JupyterLab for local file path selection and adds an input field for external files URL. This is done currently for
GeoJSON,ShapeFileandImageSourcesources (every source that has apathfield)📚 Documentation preview: https://jupytergis--335.org.readthedocs.build/en/335/
💡 JupyterLite preview is available from the doc, by clicking on