Conversation
|
Integration tests report: appsharing.space |
|
This is great, thanks for working on this @gjmooney.
I don't know how complicated it is, but having it configurable would be wonderful, from the settings or a context menu on the bar itself. |
|
This is absolutely beautiful, Greg! I love having the projection info always displayed in the bottom-right like QGIS. What do you think of also including a "scale" indicator on the bar to meaningfully indicate zoom level? Similar to QGIS, expressed as a ratio of |
|
Huge nitpick: The JGIS version number and the right edge of the loading bar bounce around the slightest bit when the coordinates update. |
|
Ooh, we could also display the coordinate system's units in the status bar. It's going to be meters in most cases, but EPSG4326 is a common choice with units in degrees. Looks like it returns |
Yea that would be ideal, I think that'd be better for a future PR though. |
|
please update snapshots |
|
please update snapshots |
|
please update snapshots now |
|
Triggering a rebuild |
|
please update snapshots you useless bot |
Bot might get offended 🤧 |
|
pretty please update snapshots |
martinRenou
left a comment
There was a problem hiding this comment.
Thanks, looks great!! Let's merge this and iterate
* Add status bar * Get loading state from mainView * Add version to statusbar * Add scale and units * Stop coords from bouncing around * Import sort * Use theme color for bar bg * Update Playwright Snapshots --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
Addresses #306, #316, and maybe #309
Adds a status bar to the map showing a loading indicator, version number, coordinates, and view projection.
I'd appreciate some input on how it looks and which information we want to put on it.
Loading:

Loaded:

EDIT: Updated with scale and units

Checklist
Resolves #XXX.Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lint📚 Documentation preview: https://jupytergis--348.org.readthedocs.build/en/348/
💡 JupyterLite preview is available from the doc, by clicking on