Skip to content

Add status bar to map#348

Merged
martinRenou merged 8 commits intogeojupyter:mainfrom
gjmooney:status_bar
Jan 20, 2025
Merged

Add status bar to map#348
martinRenou merged 8 commits intogeojupyter:mainfrom
gjmooney:status_bar

Conversation

@gjmooney
Copy link
Collaborator

@gjmooney gjmooney commented Jan 16, 2025

Description

Addresses #306, #316, and maybe #309

Adds a status bar to the map showing a loading indicator, version number, coordinates, and view projection.

I'd appreciate some input on how it looks and which information we want to put on it.

Loading:
statubar

Loaded:
statusbarnoload

EDIT: Updated with scale and units
status2

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.
    Failing lint checks can be resolved with:
    • pre-commit run --all-files
    • jlpm run lint

📚 Documentation preview: https://jupytergis--348.org.readthedocs.build/en/348/
💡 JupyterLite preview is available from the doc, by clicking on lite badge

@gjmooney gjmooney added the enhancement New feature or request label Jan 16, 2025
@gjmooney gjmooney self-assigned this Jan 16, 2025
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch gjmooney/jupytergis/status_bar

@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2025

Integration tests report: appsharing.space

@brichet
Copy link
Collaborator

brichet commented Jan 16, 2025

This is great, thanks for working on this @gjmooney.

which information we want to put on it.

I don't know how complicated it is, but having it configurable would be wonderful, from the settings or a context menu on the bar itself.

@mfisher87
Copy link
Member

This is absolutely beautiful, Greg! I love having the projection info always displayed in the bottom-right like QGIS. What do you think of also including a "scale" indicator on the bar to meaningfully indicate zoom level? Similar to QGIS, expressed as a ratio of 1:n?

@mfisher87
Copy link
Member

mfisher87 commented Jan 16, 2025

Huge nitpick: The JGIS version number and the right edge of the loading bar bounce around the slightest bit when the coordinates update.

@mfisher87
Copy link
Member

mfisher87 commented Jan 16, 2025

Ooh, we could also display the coordinate system's units in the status bar. It's going to be meters in most cases, but EPSG4326 is a common choice with units in degrees.

Looks like it returns "m" instead of "meters" or "metres". We could label it, i.e. Units: m ... or just convert "m" to "meters".

@gjmooney
Copy link
Collaborator Author

This is great, thanks for working on this @gjmooney.

which information we want to put on it.

I don't know how complicated it is, but having it configurable would be wonderful, from the settings or a context menu on the bar itself.

Yea that would be ideal, I think that'd be better for a future PR though.

@gjmooney
Copy link
Collaborator Author

please update snapshots

@gjmooney
Copy link
Collaborator Author

please update snapshots

@martinRenou
Copy link
Member

martinRenou commented Jan 20, 2025

please update snapshots now

@martinRenou
Copy link
Member

Triggering a rebuild

@martinRenou martinRenou reopened this Jan 20, 2025
@martinRenou
Copy link
Member

please update snapshots you useless bot

@arjxn-py
Copy link
Member

please update snapshots you useless bot

Bot might get offended 🤧

@martinRenou
Copy link
Member

pretty please update snapshots

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great!! Let's merge this and iterate

@martinRenou martinRenou merged commit 1640355 into geojupyter:main Jan 20, 2025
1 of 2 checks passed
@gjmooney gjmooney deleted the status_bar branch January 20, 2025 15:38
HaudinFlorence pushed a commit to HaudinFlorence/jupytergis that referenced this pull request Jan 28, 2026
* Add status bar

* Get loading state from mainView

* Add version to statusbar

* Add scale and units

* Stop coords from bouncing around

* Import sort

* Use theme color for bar bg

* Update Playwright Snapshots

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants