Proper Styling Added for OK Button#379
Conversation
|
|
|
Integration tests report: appsharing.space |
martinRenou
left a comment
martinRenou
left a comment
There was a problem hiding this comment.
Thanks!!
Just a comment about fixing this upstream, but for now we can probably keep this.
packages/base/style/base.css
Outdated
| position: relative; | ||
| } | ||
|
|
||
| .jp-Dialog-button.jp-mod-accept.jp-mod-styled { |
There was a problem hiding this comment.
Are those classes coming from JupyterLab? If yes, I guess we should fix this upstream
There was a problem hiding this comment.
Yeah I guess so, when I inspected I found this css that's being applied to it and we are using these classes for the OK buttons in both JupyterGIS and JupyterCAD .jp-mod-styled.jp-mod-accept.
button.jp-mod-styled.jp-mod-accept {
background: var(--jp-accept-color-normal, var(--md-blue-500, #2196f3));
border: 0;
color: white;
}
There was a problem hiding this comment.
Would you like to open a PR upstream for fixing this in JupyterLab?
There was a problem hiding this comment.
it's in packages/application/style/buttons.css in jupyterlab.
There was a problem hiding this comment.
Also we should probably put a comment here in our code saying this is being upstreamed. So on the long run we just remove that rule.
There was a problem hiding this comment.
Do you think the same applies to .jp-mod-styled.jp-mod-reject ? Do we also have a problem with those buttons ?
There was a problem hiding this comment.
Probably yes, if it does not use a lab CSS variable
* added styling for OK button * reject button proper styling.
2 participants
Description
Fixes #375.
Checklist
Resolves #XXX.Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lint📚 Documentation preview: https://jupytergis--379.org.readthedocs.build/en/379/
💡 JupyterLite preview: https://jupytergis--379.org.readthedocs.build/en/379/lite