Skip to content

Proper Styling Added for OK Button #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martinRenou merged 2 commits into from
Jan 22, 2025
Merged

Proper Styling Added for OK Button #379

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31f4c64
added styling for OK button
Meriem-BenIsmail Jan 21, 2025
540b628
reject button proper styling.
Meriem-BenIsmail Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/base/style/base.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,3 +49,7 @@
display: block;
position: relative;
}

.jp-Dialog-button.jp-mod-accept.jp-mod-styled {
Copy link
Member

@martinRenou martinRenou Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are those classes coming from JupyterLab? If yes, I guess we should fix this upstream

Copy link
Member Author

@Meriem-BenIsmail Meriem-BenIsmail Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I guess so, when I inspected I found this css that's being applied to it and we are using these classes for the OK buttons in both JupyterGIS and JupyterCAD .jp-mod-styled.jp-mod-accept.

button.jp-mod-styled.jp-mod-accept {
  background: var(--jp-accept-color-normal, var(--md-blue-500, #2196f3));
  border: 0;
  color: white;
}

Copy link
Member

@martinRenou martinRenou Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you like to open a PR upstream for fixing this in JupyterLab?

Copy link
Member Author

@Meriem-BenIsmail Meriem-BenIsmail Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's in packages/application/style/buttons.css in jupyterlab.

Copy link
Member

@martinRenou martinRenou Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also we should probably put a comment here in our code saying this is being upstreamed. So on the long run we just remove that rule.

Copy link
Member Author

@Meriem-BenIsmail Meriem-BenIsmail Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay I will !

Copy link
Member Author

@Meriem-BenIsmail Meriem-BenIsmail Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think the same applies to .jp-mod-styled.jp-mod-reject ? Do we also have a problem with those buttons ?

Copy link
Member

@martinRenou martinRenou Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably yes, if it does not use a lab CSS variable

background-color: var(--jp-brand-color1) !important;
}
Loading