Fix scale indicator in notebooks and symbology overflow#408
Merged
martinRenou merged 4 commits intogeojupyter:mainfrom Jan 30, 2025
Merged
Fix scale indicator in notebooks and symbology overflow#408martinRenou merged 4 commits intogeojupyter:mainfrom
martinRenou merged 4 commits intogeojupyter:mainfrom
Conversation
Contributor
|
|
gjmooney
changed the title
Contributor
|
Integration tests report: appsharing.space |
Collaborator
Author
|
please update snapshots |
1 similar comment
Collaborator
Author
|
please update snapshots |
This was
linked to
issues
Jan 29, 2025
HaudinFlorence
pushed a commit
to HaudinFlorence/jupytergis
that referenced
this pull request
Jan 28, 2026
* Stop console spam * Fix symbology CSS * Remove initializedPostion and only that * Update Playwright Snapshots --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Includes fixes for #394 and #407, and gets rid of some console spam when first creating a layer.
As part of the fix for #394 I removed the
_initializedPositionboolean from the main view, I'm pretty sure that was a work around for a MapLibre issue.I also removed🤡_onSharedOptionsChangedsince it wasn't doing anything previously (as_initializedPositionwastruemost of the time) and it fires whenever any collaborator moves their map.That raises an issue, since any collaborator moving around the map or zooming changes the
optionsin the file that might lead to unwanted or unexpected behavior.Checklist
Resolves #XXX.Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lint📚 Documentation preview: https://jupytergis--408.org.readthedocs.build/en/408/
💡 JupyterLite preview: https://jupytergis--408.org.readthedocs.build/en/408/lite