Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ const Heatmap = ({

return (
<div className="jp-gis-layer-symbology-container">
<div className="jp-gis-symbology-row">
<div className="jp-gis-symbology-row jp-gis-heatmap">
<label htmlFor="color-ramp-select">Color Ramp:</label>
<CanvasSelectComponent
selectedRamp={selectedRamp}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export class VectorLayerPropertiesForm extends LayerPropertiesForm {
});
}
props.model.clientStateChanged.connect(() => {
if (!props.model.localState?.selected.value) {
if (!props.model.localState?.selected?.value) {
return;
}
const l = this.props.model.getLayer(
Expand Down
16 changes: 2 additions & 14 deletions packages/base/src/mainview/mainView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -263,10 +263,6 @@ export class MainView extends React.Component<IProps, IStates> {
});

this._Map.on('moveend', () => {
if (!this._initializedPosition) {
return;
}

const currentOptions = this._model.getOptions();

const view = this._Map.getView();
Expand Down Expand Up @@ -319,7 +315,6 @@ export class MainView extends React.Component<IProps, IStates> {
);
const options = this._model.getOptions();
this.updateOptions(options);
this._initializedPosition = true;
}

this._Map.getViewport().addEventListener('contextmenu', event => {
Expand Down Expand Up @@ -1298,16 +1293,10 @@ export class MainView extends React.Component<IProps, IStates> {
});
};

private _onSharedOptionsChanged(
sender?: IJupyterGISDoc,
change?: MapChange
): void {
if (!this._initializedPosition) {
private _onSharedOptionsChanged(): void {
if (!this.state.remoteUser) {
const options = this._model.getOptions();

this.updateOptions(options);

this._initializedPosition = true;
}
}

Expand Down Expand Up @@ -1766,7 +1755,6 @@ export class MainView extends React.Component<IProps, IStates> {

private _clickCoords: Coordinate;
private _commands: CommandRegistry;
private _initializedPosition = false;
private divRef = React.createRef<HTMLDivElement>(); // Reference of render div
private _Map: OlMap;
private _model: IJupyterGISModel;
Expand Down
7 changes: 2 additions & 5 deletions packages/base/style/symbologyDialog.css
Original file line number Diff line number Diff line change
Expand Up @@ -210,11 +210,8 @@ select option {
border-radius: var(--jp-border-radius);
}

.jp-Dialog-content:has(.jp-gis-color-canvas-display) {
overflow: visible;
}

.jp-Dialog-body:has(.jp-gis-color-canvas-display) {
.jp-Dialog-content:has(.jp-gis-heatmap),
.jp-Dialog-body:has(.jp-gis-heatmap) {
overflow: visible;
}

Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading