Don't change paths to absolute backend paths#425
Closed
davidbrochart wants to merge 1 commit intogeojupyter:mainfrom
Closed
Don't change paths to absolute backend paths#425davidbrochart wants to merge 1 commit intogeojupyter:mainfrom
davidbrochart wants to merge 1 commit intogeojupyter:mainfrom
Conversation
Contributor
Contributor
|
Integration tests report: appsharing.space |
Collaborator
Author
|
This is not the final solution, but using a backend absolute path and passing that to the frontend cannot work in the general case. |
Member
|
Thanks @davidbrochart ! Well, CI is passing and testing the Python API from the notebook. Let's merge? |
Collaborator
Author
Hmm I think the |
Member
|
We're supposed to have visual regression tests running this notebook, I'm not sure why it doesn't complain |
Collaborator
Author
|
Maybe Jupyter is launched inside |
4 tasks
Member
|
Closing as it's already included as part of #412 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #352.
Checklist
Resolves #XXX.Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lint📚 Documentation preview: https://jupytergis--425.org.readthedocs.build/en/425/
💡 JupyterLite preview: https://jupytergis--425.org.readthedocs.build/en/425/lite