Skip to content

Don't change paths to absolute backend paths #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davidbrochart wants to merge 1 commit into from
Closed

Don't change paths to absolute backend paths #425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions python/jupytergis_lab/jupytergis_lab/notebook/gis_document.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
LayerType,
SourceType,
)
from .utils import normalize_path

logger = logging.getLogger(__file__)

Expand Down Expand Up @@ -708,7 +707,7 @@ def _path_to_comm(cls, filePath: Optional[str]) -> Dict:
contentType = None

if filePath is not None:
path = normalize_path(filePath)
path = filePath
file_name = Path(path).name
try:
ext = file_name.split(".")[1].lower()
Expand Down
8 changes: 0 additions & 8 deletions python/jupytergis_lab/jupytergis_lab/notebook/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import os
from enum import Enum
from urllib.parse import urljoin
import requests
Expand All @@ -16,10 +15,3 @@ def multi_urljoin(*parts) -> str:
parts[0],
"/".join(part for part in parts[1:]),
)


def normalize_path(path: str) -> str:
if os.path.isabs(path):
return path
else:
return os.path.abspath(os.path.join(os.getcwd(), path))
Loading