Introduce Custom Settings for JupyterGIS#619
Conversation
|
|
|
Currently having the failure - cc: @martinRenou |
|
Integration tests report: appsharing.space |
| "access": "public" | ||
| }, | ||
| "jupyterlab": { | ||
| "schemaDir": "schema", |
There was a problem hiding this comment.
Line 17 of this file, you want to list the schema folder as part of the package file
Co-authored-by: martinRenou <martin.renou@gmail.com>
arjxn-py
changed the title
martinRenou
left a comment
martinRenou
left a comment
There was a problem hiding this comment.
Thanks!!
Here you are using a global settingsState. This will not work well for listening to settings changes.
Instead you should probably pass around the settingRegistry to the JupyterGISModelFactory, and add a new constructor option to the JupyterGISModel so that it can own the settingRegistry and listen to setting changes there.
arjxn-py
changed the title
Failure diff fow lite deployment on this PR, strange because when i check it works fine on RTD |
|
@arjxn-py could you write a description for this PR? |
Done, thanks to recall that :) |
|
Thanks for adding it :) |
packages/schema/src/interfaces.ts
Outdated
| contentsManager: Contents.IManager | undefined; | ||
| filePath: string; | ||
|
|
||
| getSettings(): any; |
There was a problem hiding this comment.
Can we get better typing than this?
There was a problem hiding this comment.
Especially, the any is shadowing the fact that it can be null.
There was a problem hiding this comment.
Sure, i'll look into this
|
The failure is legit, i'll look into it |
Co-authored-by: martinRenou <martin.renou@gmail.com>
* Settings to configure proxy url * don't use async method maybe * Add settings to core * Update python/jupytergis_core/src/jgisplugin/plugins.ts Co-authored-by: martinRenou <martin.renou@gmail.com> * list the schema folder as part of the package file * get settings in tools.ts * lint * settingsregistry to model * use settings * lint * load settings at plugin level * investigate the culprit * lint * have more specific type * Add temporary fallback * handling for jupyterlite * Update packages/base/src/tools.ts Co-authored-by: martinRenou <martin.renou@gmail.com> * lint * lint --------- Co-authored-by: martinRenou <martin.renou@gmail.com>
3 participants
Description
Shall close #456
This PR introduces support for custom settings in JupyterGIS, addressing the current limitation of the hardcoded third-party CORS proxy used in
tools.ts. The proxy URL is now configurable via the JupyterLab Settings UI, allowing users to specify their own proxy endpoint or disable it entirely.settings.mp4
Checklist
Resolves #XXX.Failing lint checks can be resolved with:
pre-commit run --all-filesjlpm run lint📚 Documentation preview: https://jupytergis--619.org.readthedocs.build/en/619/
💡 JupyterLite preview: https://jupytergis--619.org.readthedocs.build/en/619/lite