-
Notifications
You must be signed in to change notification settings - Fork 69
Introduce Custom Settings for JupyterGIS #619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
c3b676d
Settings to configure proxy url
arjxn-py 6b0b6ff
don't use async method maybe
arjxn-py f281e61
Add settings to core
arjxn-py 6b6e043
Merge branch 'main' into settings
arjxn-py 6dc7ec5
Update python/jupytergis_core/src/jgisplugin/plugins.ts
arjxn-py 38b0570
list the schema folder as part of the package file
arjxn-py 883faba
get settings in tools.ts
arjxn-py 527d95f
lint
arjxn-py f2e3712
settingsregistry to model
arjxn-py 364afc8
use settings
arjxn-py 3acf47d
lint
arjxn-py e92597c
load settings at plugin level
arjxn-py eec142c
Merge branch 'main' into settings
arjxn-py fd13337
Merge branch 'main' into settings
arjxn-py 4cef6f0
investigate the culprit
arjxn-py 6a014c2
lint
arjxn-py 97f6431
have more specific type
arjxn-py 7cc0ec7
Merge branch 'main' into settings
arjxn-py c5aae3c
Add temporary fallback
arjxn-py 6373bd6
handling for jupyterlite
arjxn-py 8920b1a
Update packages/base/src/tools.ts
arjxn-py dc230b3
lint
arjxn-py 1d64c77
lint
arjxn-py fe65608
Merge branch 'main' into settings
arjxn-py File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| { | ||
| "title": "JupyterGIS Settings", | ||
| "description": "Settings for the JupyterGIS extension.", | ||
| "type": "object", | ||
| "properties": { | ||
| "proxyUrl": { | ||
| "type": "string", | ||
| "title": "Proxy URL", | ||
| "description": "The proxy URL to use for external requests.", | ||
| "default": "https://corsproxy.io/" | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 17 of this file, you want to list the schema folder as part of the package file