Fill vertical space in linked output & sidecar views

[SylvainCorlay]

Currently, when displaying a GISDocument widget, it will always have a fixed height of 600px. This is problematic when opening the widget in a sidecar or a "linked output" view, as the widget will either take up a small portion of the height of the container or it will extend beyond the bottom of the container and require the user to scroll.

This PR sets the height to 100% in both of those contexts.

"Linked output" view can be opened by right-clicking the gutter space to the left of a widget and selecting "Create new view for cell output".

Sidecar view can be opened with jupyterlab-sidecar.

Extracted from PR #340.

---

📚 Documentation preview: https://jupytergis--643.org.readthedocs.build/en/643/
💡 JupyterLite preview: https://jupytergis--643.org.readthedocs.build/en/643/lite

[github-actions]

👈 Launch a Binder on branch SylvainCorlay/jupytergis/mirrored-view

[github-actions]

Integration tests report: appsharing.space

[arjxn-py]

Thanks!

[mfisher87]

I'm not sure why, but I'm getting an empty map view with this change. The toolbar is visible (sometimes), but the map is not. Adding new layers through the toolbar updates the ydoc, but the map remains blank. Tested in firefox and chromium, same result.

Back on the sidecar-experiment branch, I can still call explore("some_geo.json") and get a working sidecar panel. However, now opening cell output in new view is no longer working. Sometimes the toolbar shows up, sometimes it doesn't. And the map is never showing up (except when using explore(...)). Is anyone else able to reproduce?

This was absolutely not happening when I demoed yesterday, and nothing has changed... I'm extremely confused.

In the panes without toolbars, the expected divs aren't even present. In the panes with toolbars, manually changing the height from 100% to any pixel value in the browser debug tools causes the map to display correctly.

I used examples/Notebook.ipynb and examples/jgis.ipynb to reproduce this behavior. I tried both opening a new view with right click on the gutter to the left, and manually creating sidecars 🤯

These behaviors seem contradictory. If it's the CSS, how come only opening a sidecar from the Python API is working and manually opening a sidecar to display a doc is not? If it's not the CSS, how come changing height from 100% to 600px fixes the map?

[SylvainCorlay]

I opened jupyterlab/jupyterlab#17487 upstream in core lab so that we get the correct behavior. It also fixes the behavior in ipyleaflet.

[martinRenou]

Thanks! 🚀

Should we merge this since the other mentioned issue will be fixed upstream?

[arjxn-py]

Unblocking it :)