Skip to content

Introduce settings to optionally disable some features (filtering/annotations etc)#898

Merged
martinRenou merged 14 commits intogeojupyter:mainfrom
arjxn-py:visibility-menu
Aug 27, 2025
Merged

Introduce settings to optionally disable some features (filtering/annotations etc)#898
martinRenou merged 14 commits intogeojupyter:mainfrom
arjxn-py:visibility-menu

Conversation

@arjxn-py
Copy link
Member

@arjxn-py arjxn-py commented Aug 25, 2025

Description

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.
    Failing lint checks can be resolved with:
    • pre-commit run --all-files
    • jlpm run lint

📚 Documentation preview: https://jupytergis--898.org.readthedocs.build/en/898/
💡 JupyterLite preview: https://jupytergis--898.org.readthedocs.build/en/898/lite

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch arjxn-py/jupytergis/visibility-menu

@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2025

Integration tests report: appsharing.space

@arjxn-py arjxn-py marked this pull request as ready for review August 26, 2025 15:36
@arjxn-py arjxn-py added the enhancement New feature or request label Aug 26, 2025
@martinRenou martinRenou changed the title Toggle Visibility of Panels and Tabs Introduce settings to optionally disable some features (filtering/annotations etc) Aug 26, 2025
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou
Copy link
Member

The failure is legit, I'm looking into it

@martinRenou martinRenou merged commit 36fc964 into geojupyter:main Aug 27, 2025
14 checks passed
mfisher87 pushed a commit to mapninja/jupytergis-docwork that referenced this pull request Aug 28, 2025
…otations etc) (geojupyter#898)

* Toggle Visibility of Panels and Tabs

* cleanup

* use model's settingschanged

* ready

* lint

* remove flags

* don't show if all tabs are disabled

* remove toolbar menu for now

* disable identify command if identify is disabled in settings

* refactor settings change handling to emit specific keys when settings are updated

* Bring back spacer + small cleanup

* Fix notebook renderer

* Fix missing settings registry for notebook renderer

* Linter

---------

Co-authored-by: martinRenou <martin.renou@gmail.com>
HaudinFlorence pushed a commit to HaudinFlorence/jupytergis that referenced this pull request Jan 28, 2026
…otations etc) (geojupyter#898)

* Toggle Visibility of Panels and Tabs

* cleanup

* use model's settingschanged

* ready

* lint

* remove flags

* don't show if all tabs are disabled

* remove toolbar menu for now

* disable identify command if identify is disabled in settings

* refactor settings change handling to emit specific keys when settings are updated

* Bring back spacer + small cleanup

* Fix notebook renderer

* Fix missing settings registry for notebook renderer

* Linter

---------

Co-authored-by: martinRenou <martin.renou@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants