remove collision arrays from Data and utilize CollisionContext inline#1067
Open
thowell wants to merge 1 commit intogoogle-deepmind:mainfrom
Open
remove collision arrays from Data and utilize CollisionContext inline#1067thowell wants to merge 1 commit intogoogle-deepmind:mainfrom
Data and utilize CollisionContext inline#1067thowell wants to merge 1 commit intogoogle-deepmind:mainfrom
Conversation
thowell
force-pushed
the
collisioncontext
branch
2 times, most recently
from
da216c6 to
80e7607
Compare
thowell
force-pushed
the
collisioncontext
branch
from
80e7607 to
6fecb1f
Compare
erikfrey
approved these changes
Feb 5, 2026
Collaborator
erikfrey
left a comment
erikfrey
left a comment
There was a problem hiding this comment.
Looks great, just one nit
| from mujoco_warp import DisableBit | ||
| from mujoco_warp import test_data | ||
| from mujoco_warp._src import collision_driver | ||
| from mujoco_warp._src.collision_driver import create_collision_context |
Collaborator
There was a problem hiding this comment.
style nit: since you already imported collision_driver right above, and you only reference create_collision_context in one place, I'd just use the module reference and delete this extra import.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.