Optimization: Tiles version of efc_contact kernels#1087
Draft
Kenny-Vilella wants to merge 15 commits intogoogle-deepmind:mainfrom
Draft
Optimization: Tiles version of efc_contact kernels#1087Kenny-Vilella wants to merge 15 commits intogoogle-deepmind:mainfrom
Kenny-Vilella wants to merge 15 commits intogoogle-deepmind:mainfrom
Conversation
…mental_contact_efc
Collaborator
Author
|
Some perf number from my RTX 4080, median of 5 runs:
|
Collaborator
Author
|
@thowell I saw that you have recently changed the This PR tries to optimize the two efc_contact kernels, basically decreases by 50% the time of the efc_contact kernels. I wonder what are the critical functionalities that I should maintain for the sparse Jacobian? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List of change:
In total one more kernel and 1 more model property and 2 more data properties.
Will add perf number and some more description later on.