Add docstring to gjk_normalize function#1114
Open
arushsinghal wants to merge 2 commits intogoogle-deepmind:mainfrom
Open
Add docstring to gjk_normalize function#1114arushsinghal wants to merge 2 commits intogoogle-deepmind:mainfrom
arushsinghal wants to merge 2 commits intogoogle-deepmind:mainfrom
Conversation
- Create centralized assert_allclose() function in conftest.py - Unifies tolerance configuration across all test files - Maintains backward compatibility with local _assert_eq() wrappers - Reduces code duplication: 6 test files previously had duplicate assertion logic - Supports custom tolerance multipliers per test file - Single source of truth for test tolerance settings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Google-style docstring to the gjk_normalize utility function explaining its bounds checking behavior for the GJK algorithm.