Conversation
| @@ -1,114 +1,157 @@ | |||
| [versions] | |||
| # Project Configuration | |||
| androidGradlePlugin = "8.13.2" | |||
Check warning
Code scanning / Android Lint
Obsolete Android Gradle Plugin Version Warning
| @@ -1,114 +1,157 @@ | |||
| [versions] | |||
| # Project Configuration | |||
| androidGradlePlugin = "8.13.2" | |||
Check warning
Code scanning / Android Lint
Obsolete Android Gradle Plugin Version Warning
| javaVersion = "17" | ||
|
|
||
| # Kotlin & Coroutines | ||
| kotlin = "2.2.0" |
Check warning
Code scanning / Android Lint
Obsolete Gradle Dependency Warning
| javaVersion = "17" | ||
|
|
||
| # Kotlin & Coroutines | ||
| kotlin = "2.2.0" |
Check warning
Code scanning / Android Lint
Obsolete Gradle Dependency Warning
| javaVersion = "17" | ||
|
|
||
| # Kotlin & Coroutines | ||
| kotlin = "2.2.0" |
Check warning
Code scanning / Android Lint
Newer Library Versions Available Warning
| kotlinxDatetime = "0.7.1" | ||
| kotlinxCoroutinesTest = "1.10.2" | ||
| robolectric = "4.16" | ||
| hilt = "2.57.2" |
Check warning
Code scanning / Android Lint
Newer Library Versions Available Warning
| kotlinxDatetime = "0.7.1" | ||
| kotlinxCoroutinesTest = "1.10.2" | ||
| robolectric = "4.16" | ||
| hilt = "2.57.2" |
Check warning
Code scanning / Android Lint
Newer Library Versions Available Warning
| kotlinxDatetime = "0.7.1" | ||
| kotlinxCoroutinesTest = "1.10.2" | ||
| robolectric = "4.16" | ||
| hilt = "2.57.2" |
Check warning
Code scanning / Android Lint
Newer Library Versions Available Warning
|
@dkhawk , this looks good. Let's wait until the other libraries are published, update them here and merge this PR. |
023d41a to
9752d55
Compare
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
- Upgrade Google Maps SDK to v20.0.0 (BREAKING CHANGE: requires new renderer). - Fix WearOS build by replacing deprecated kotlinOptions with jvmToolchain. - Resolve WearOS dependency conflicts by using Kotlin BOM. - Migrate WearOS dependencies and SDK versions to Version Catalog. - Refactor Version Catalog: extract versions and organize groups. - Fix FireMarkers sample: correct Google Services plugin application logic. - FireMarkers: Add explicit error handling for 'Permission Denied'. BREAKING CHANGE: This release upgrades the Maps SDK to v20.0.0, which may require code changes for the new renderer and other API adjustments.
- Create scripts/verify_all.sh for local verification - Update CI to run tests and lint - Remove deprecated snippets/app-rx module - Fix FireMarkers unit tests - Update README with verification instructions
9752d55 to
81f2207
Compare
|
@dkhawk , we would need to check where the snippets from the Rx samples are being used, since the tags are being removed. |
| dependencies { | ||
| // [START_EXCLUDE] | ||
| implementation("androidx.core:core-ktx:1.15.0") | ||
| implementation("org.jetbrains.kotlin:kotlin-stdlib-jdk7:2.0.21") |
There was a problem hiding this comment.
We are keeping this dependencies as numerics, so they can be read from the region tag.
| materialIconsExtended = "1.7.8" | ||
|
|
||
| # Google Maps & Places | ||
| mapsCompose = "7.0.0" |
Check warning
Code scanning / Android Lint
Newer Library Versions Available Warning
| # Testing | ||
| espresso = "3.7.0" | ||
| junit = "4.13.2" | ||
| mockito = "6.2.2" |
Check warning
Code scanning / Android Lint
Newer Library Versions Available Warning
settings.gradle.kts
Outdated
| } | ||
| } | ||
| plugins { | ||
| id("org.gradle.toolchains.foojay-resolver-convention") version "1.0.0" |
There was a problem hiding this comment.
What about adding this on the version catalog?
settings.gradle.kts
Outdated
| dependencyResolutionManagement { | ||
| repositoriesMode.set(RepositoriesMode.FAIL_ON_PROJECT_REPOS) | ||
| repositories { | ||
| mavenLocal() |
There was a problem hiding this comment.
Do we want to keep this line? mavenLocal() it is probably something that should be done intentionally, otherwise the local .m2 repository will end up packed.
- CI: Upgrade to Java 21 and add python docs check - Settings: Allow local repository overrides - Docs: Annotate WearOS dependencies with hardcoded versions
|
All requested changes have been addressed:
Ready for final review! |
|
Addressed all feedback:
|
Description
Establishes a robust build verification pipeline and removes deprecated Rx samples.
Changes
scripts/verify_all.sh: A single script to verify all modules locally (Assemble + Test + Lint)..github/workflows/build.ymlto run unit tests and lint checks.mock-maker-inlineforFireMarkersto fix testing final classes.MarkersViewModelTest.snippets:app.Verification
Run
./scripts/verify_all.shto verify the entire project.