Skip to content

fix: read codebase conventions during new-project for brownfield projects #935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amanape wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −1
Open

fix: read codebase conventions during new-project for brownfield projects #935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99ce9de
fix: read codebase conventions during new-project questioning for bro…
amanape Mar 4, 2026
7596249
fix: narrow codebase reads to CONVENTIONS.md only
amanape Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ Format follows [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).

## [Unreleased]

### Fixed
- Brownfield projects: `/gsd:new-project` now reads CONVENTIONS.md during questioning and PROJECT.md creation — prevents re-asking questions already answered by existing codebase conventions

## [1.22.4] - 2026-03-03

### Added
Expand Down
8 changes: 7 additions & 1 deletion get-shit-done/workflows/new-project.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,12 @@ Proceed to Step 4 (skip Steps 3 and 5).
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
```

**If `has_codebase_map` is true:** Load existing codebase context before questioning.

Read `.planning/codebase/CONVENTIONS.md` (if it exists) — coding standards, file organization, naming patterns.

Use this context to avoid re-asking questions already answered by existing conventions and to ground follow-up questions in established patterns.

**Open the conversation:**

Ask inline (freeform, NOT AskUserQuestion):
Expand Down Expand Up @@ -292,7 +298,7 @@ All Active requirements are hypotheses until shipped and validated.

Infer Validated requirements from existing code:

1. Read `.planning/codebase/ARCHITECTURE.md` and `STACK.md`
1. Read `.planning/codebase/ARCHITECTURE.md`, `STACK.md`, and `CONVENTIONS.md`
2. Identify what the codebase already does
3. These become the initial Validated set

Expand Down